Feature 1074: Added the capabilities field in patcher manifest #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genail
approved these changes
Nov 4, 2018
witcher112
requested changes
Nov 5, 2018
| private const int ManifestVersion = 4; | ||
|
|
||
| [MenuItem("Tools/PatchKit Patcher/Manifest/Windows")] | ||
| private static void Test(Manifest manifest) |
Contributor
There was a problem hiding this comment.
Are you sure we want to leave test methods here?
Contributor
Author
There was a problem hiding this comment.
These methods serve as a quick way to manually verify if the manifest generates correctly.
I'll change their names though to make it clearer.
witcher112
requested changes
Nov 22, 2018
| File.WriteAllText(targetLocation, JsonConvert.SerializeObject(manifest, Formatting.Indented)); | ||
| } | ||
|
|
||
| [MenuItem("Tools/PatchKit Patcher/Manifest/Windows")] |
Contributor
There was a problem hiding this comment.
If we are not removing these methods, can we wrap them inside #if with some new define named PATCHKIT_PATCHER_UNITY_DEV or use another if such already exist?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Version.csupdate - if required